refactor to simplify handling json streams#13754
Draft
thaJeztah wants to merge 3 commits intodocker:mainfrom
Draft
refactor to simplify handling json streams#13754thaJeztah wants to merge 3 commits intodocker:mainfrom
thaJeztah wants to merge 3 commits intodocker:mainfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Removes the need to manually convert to a string. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Apr 21, 2026
| } | ||
| } | ||
|
|
||
| err = jsonmessage.DisplayJSONMessagesStream(response.Body, buildBuff, progBuff.FD(), true, aux) |
Member
Author
There was a problem hiding this comment.
Not sure if this one works; the old code was unconditionally setting "terminal" to "true".
thaJeztah
commented
Apr 21, 2026
Comment on lines
-181
to
184
| exposed.Add(strconv.Itoa(int(p.Num()))) | ||
| exposed.Add(p.Port()) | ||
| } | ||
| for _, port := range service.Ports { | ||
| exposed.Add(strconv.Itoa(int(port.Target))) |
Member
Author
There was a problem hiding this comment.
Not introduced in my changes, but wondering if this code is correct, or if it should preserve the protocol (tcp, udp, ...) https://docs.docker.com/reference/compose-file/services/#expose
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did