Conversation
whalelines
left a comment
whalelines
left a comment
There was a problem hiding this comment.
The latest docker-library PR, docker-library/official-images#16141, appears to be adding azul-zulu, so the path of these files should be updated from zulu/ to azul-zulu/.
azul-zulu/content.md
Outdated
| * Azul Zulu 17 based on Ubuntu: | ||
| ``` | ||
| docker run -it --rm azul/azul-zulu:17 java -version | ||
| ``` | ||
| * Azul Zulu 17 based on Debian: | ||
| ``` | ||
| docker run -it --rm azul/azul-zulu-debian:17 java -version | ||
| ``` | ||
| * Azul Zulu 17 based on CentOS: | ||
| ``` | ||
| docker run -it --rm azul/azul-zulu-centos:17 java -version | ||
| ``` | ||
| * Azul Zulu 17 based on Alpine: | ||
| ``` | ||
| docker run -it --rm azul/azul-zulu-alpine:17 java -version | ||
| ``` | ||
| * Azul Zulu 17 based on Distroless: | ||
| ``` | ||
| docker run -it --rm azul/azul-zulu-distroless:17 --version | ||
| ``` |
There was a problem hiding this comment.
These commands still all reference non-existent images. The PR to create a new DOI, docker-library/official-images#14593 , would create the images in the repository azul-zulu-openjdk, so the images would look something like azul-zulu-openjdk:17-ubuntu, i.e., there is no namespace and the base image type appears in the tag, not the repository.
There was a problem hiding this comment.
correct @whalelines, I modified this pull request to align with DOI merge request docker-library/official-images#16141.
But this means both pull requests should get approved and published together?
FYI as mentioned in the last comment in docker-library/official-images#14593, the correct merge request for DOI Azul Zulu is docker-library/official-images#16141
|
great, thank you, and can you also merge it, @LaurentGoderre? |
|
Your continued patience is appreciated. |
|
This documentation proposal has been updated to align with the pull request |
yosifkit
left a comment
yosifkit
left a comment
There was a problem hiding this comment.
Just a couple comments/questions.
yosifkit
left a comment
yosifkit
left a comment
There was a problem hiding this comment.
LGTM.
Side note:
With all the extra commits in your branch, and our use of squash-and-merge in GitHub, it'll likely cause your branch to continue to grow with more Merge branch 'docker-library:master' into [branch] commits along with your past commits that were squash & merged. You'll likely want to rebase your branch on docker-library/docs/master (or just start a new branch from docker-library/docs/master each time you make a PR).
Some helpful links:
- https://git-scm.com/book/en/v2/Git-Branching-Rebasing
- https://github.com/servo/servo/wiki/Beginner's-guide-to-rebasing-and-squashing#rebasing
- https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase
- docker-library/official-images#426 (comment)
- docker-library/official-images#2245 (comment)
| ## Azul Zulu Images | ||
|
|
||
| Azul Zulu images on Docker Hub are available for different combinations of versions, packages, and systems. | ||
|
|
||
| ### Versions | ||
|
|
||
| The following Long Term Support (LTS) versions are available: | ||
|
|
||
| - 8 | ||
| - 11 | ||
| - 17 | ||
| - 21 | ||
| - 25 | ||
|
|
||
| Short Term Support (STS) versions are available for six months after their initial release. | ||
|
|
||
| ### Packages | ||
|
|
||
| The following package types are available: | ||
|
|
||
| - jdk (default) | ||
| - jdk-headless | ||
| - jre | ||
| - jre-headless | ||
|
|
||
| ### Systems | ||
|
|
||
| Images based on the following base systems are available: | ||
|
|
||
| - Debian (apt) |
There was a problem hiding this comment.
Instead of such a verbose set of lists that then have to be maintained over time, what do you think about describing the tag scheme/methodology here? (IMO it's already pretty obvious from the tags, but I might be skewed from looking at this kind of thing all day every day 😂)
| Using Azul Zulu based on Debian: | ||
|
|
||
| ```bash | ||
| docker run -it --rm azul-zulu:<ZULU_VERSION>-debian<DISTRO_VERSION> java -version |
There was a problem hiding this comment.
| docker run -it --rm azul-zulu:<ZULU_VERSION>-debian<DISTRO_VERSION> java -version | |
| docker run -it --rm %%IMAGE%%:<ZULU_VERSION>-debian<DISTRO_VERSION> java -version |
| FROM azul-zulu:<VERSION> | ||
| RUN mkdir /opt/my-app | ||
| COPY my-app.jar /opt/my-app |
There was a problem hiding this comment.
| FROM azul-zulu:<VERSION> | |
| RUN mkdir /opt/my-app | |
| COPY my-app.jar /opt/my-app | |
| FROM %%IMAGE%%:<VERSION> | |
| COPY my-app.jar /opt/my-app/ |
| @@ -0,0 +1 @@ | |||
| https://github.com/AzulSystems/azul-zulu-images/issues | |||
There was a problem hiding this comment.
The default for this file with be very similar to this (the ?q= on the end of the link here makes it show all issues by default, even closed, so you're less likely to get duplicates of recently closed issues):
[%%GITHUB-REPO%%/issues](%%GITHUB-REPO%%/issues?q=)(so this file should be removed completely)
There was a problem hiding this comment.
Just as an FYI, our tooling also supports a logo.svg here, if you wanted to make sure we always have enough fidelity if Docker Hub ever updates the logo resolution they support.
Proposal to add the Azul Zulu images as official images.
Relates to docker-library/official-images#14593Relates to docker-library/official-images#16141