Repository navigation
fix: restore OMP secondmates after successful generations - #205
Merged
Merged
Conversation
A wake-on-delivery restore of a remote OMP secondmate that ran at least one turn always refused: the secondmate artifact guard treated the prior incarnation's own turn-start, readiness, and doorbell markers as worker leftovers even though the recorded endpoint was proven dead or missing. When the endpoint is proven gone, the guard now refuses only unsafe artifact paths, and the prior generation's runtime markers are retired after the session-lock and integration-marker live-owner checks pass, so a live owner still refuses without losing anything.
…ion by tearing down pooled workers before session restarts, while preserving the secondmate home for later recovery cases. Full lint and both OMP tests pass. Real Herdr verification remains blocked locally by the worktree’s Unix socket path length; CI must rerun it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fix Boat F1: wake-on-delivery restore refuses a remote OMP secondmate that ran >=1 turn. In bin/fm-spawn.sh secondmate branch, OMP_SECONDMATE_RELAUNCH=1 is set when the recorded endpoint is dead/missing, but the unconditional artifact guard refused when prior-generation .omp-ext.ts/.omp-ready/.omp-started markers exist. Those markers are the prior incarnation's own runtime artifacts, not worker leftovers. When OMP_SECONDMATE_RELAUNCH=1, retire the prior generation's .omp-* artifacts via the existing spawn_omp_secondmate_abort_retire_generation (or equivalent) instead of refusing, keeping the same live-owner checks.
Acceptance criteria:
Firstmate-Validation-Generation: 628efbb1c79765e286efabc44f0aef71
What Changed
Risk Assessment
✅ Low: Captain, the change narrowly fixes prior-generation artifact retirement while preserving live-owner refusals and adding behavioral restore coverage.
Testing
The Test agent exceeded its invocation budget before live validation completed; no evidence was gathered for this head.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.