Repository navigation
interp: Remove page assumption in SIN/COS constants - #127
Merged
Merged
Conversation
Load the high byte of fp_90 explicitly in degree mode instead of asserting that fp_pi1_2 and fp_90 are in the same page. The assert failed when unrelated runtime tokens changed the code layout. Fixes #52 Aided by Opencode / DeepSeek V4.1 Flash 1017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load the high byte of fp_90 explicitly in degree mode instead of asserting that fp_pi1_2 and fp_90 are in the same page. The assert failed when unrelated runtime tokens changed the code layout.
Fixes #52