fix: use BUMPY_GH_TOKEN for draft release operations#87
Merged
Conversation
Staged publishing is not yet ready for production use. Removes npmStaged config and the npm upgrade step from the release workflow.
|
The changes in this PR will be included in the next version bump.
|
The draft release functions (createDraftRelease, updateReleaseBody, finalizeRelease, deleteRelease) were not using withReleaseToken, so GitHub release events were created with GITHUB_TOKEN which doesn't trigger downstream workflows like on-release.yaml.
theoephraim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createDraftRelease,updateReleaseBody,finalizeRelease,deleteRelease) to usewithReleaseToken— they were callingghdirectly withGITHUB_TOKEN, which doesn't trigger downstream workflows likeon-release.yamlnpm install -g npm@lateststep from the release workflowTest plan
on-release.yamltriggers when a release is finalized