fix: use BUMPY_GH_TOKEN for GitHub release creation#85
Merged
Conversation
GitHub releases created with the default GITHUB_TOKEN don't trigger downstream workflows. Now gh release create calls use BUMPY_GH_TOKEN when available, matching the existing pattern for PR and push operations. Also adds token redaction to error messages in both withReleaseToken and withPatToken to prevent leakage in CI logs.
|
The changes in this PR will be included in the next version bump.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_TOKENdon't trigger downstream workflows (a known GitHub Actions limitation). Nowgh release createcalls useBUMPY_GH_TOKENwhen available, matching the existing pattern for PR and push operations.withReleaseToken(new) andwithPatToken(existing) to prevent token leakage in CI logs.on-release.yamlworkflow to verify that release events are properly triggering downstream workflows.Test plan