docs(design): commit the Fusion context injection umbrella design (rev 5) - #114
Open
juemerson-at-purestorage wants to merge 1 commit into
Open
Conversation
…v 5) Revs 2 and 3 of this document lived only on unmerged branches (PRs dmann000#22 and dmann000#72, now closed as superseded), so every reference to docs/design/fusion-context-injection.md was dangling -- including the one in the drift report's own annotation file, which had to be repointed at the phase-1 spec. This commits the umbrella design, which is deliberately broader than the two implementation-scoped phase specs already on main: it carries the allow_errors design that Phase 2 still owes, the phasing, the empirical appendices behind the measured wire behaviour, the known spec defects the design works around, and the revision history that keeps the withdrawn cardinality-by-HTTP-verb rule traceable. No design statement changed from rev 4. The revision is limited to: a status header and implementation-status table naming what shipped (dmann000#98, dmann000#109) and what remains (dmann000#25); attribution of the API architecture consult to the FlashBlade product team rather than a named individual; and one vendor documentation sentence paraphrased instead of reproduced verbatim. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits the Fusion context injection umbrella design as rev 5 at
docs/design/fusion-context-injection.md.Why this, now
Revs 2 and 3 of this document only ever existed on unmerged branches — #22 and #72, both now closed as superseded. That left every reference to
docs/design/fusion-context-injection.mddangling, including the one in the drift report's own annotation file, which had to be repointed at the phase-1 spec while Phase 1 was being merged.The two specs already on
main(fusion-context-phase-0-spec.md,fusion-context-phase-1-spec.md) are implementation-scoped: they describe what the code does. This document is the umbrella design, and it is deliberately broader. What it carries that nothing onmaindoes:allow_errorsdesign, which Phase 2 still owes — including the rule that tolerance keys off the context's value count rather than the parameter's form, so-AllArrays -AllowErrorscan never produce a partial resultWhat changed from rev 4
No design statement changed. The revision is limited to three things:
Notes for review
is_local, and Phase 1 shippedSet-PfbContext/Clear-PfbContext/Invoke-PfbInContexttogether rather than across later phases.