Fix nthPermutation lexicographic order#10922
Open
AaritPanda-git wants to merge 1 commit intodlang:masterfrom
Open
Fix nthPermutation lexicographic order#10922AaritPanda-git wants to merge 1 commit intodlang:masterfrom
AaritPanda-git wants to merge 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @AaritPanda-git! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
10d109a to
d10b99a
Compare
Fix Bugzilla issue 10849
d10b99a to
6fc2129
Compare
Author
|
Gentle ping @PetarKirov in case this slipped through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10849
This PR fixes nthPermutation to always produce permutations in
lexicographic order, as implied by the Lehmer code representation
described in the documentation.
When the Lehmer code has leading zeros (idx < range.length),
the previous implementation lost these during reversal, resulting
in incorrect ordering. The fix preserves the leading zeros and
restores correct lexicographic behavior.