Open
Conversation
dzharkov
suggested changes
Apr 30, 2018
TicTacToe/.idea/compiler.xml
Outdated
| @@ -0,0 +1,23 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
В чем смысл хранения .idea в репозитории для гредл проекта? Пока -2
| * @param board current board | ||
| * @return point where the turn is made | ||
| */ | ||
| Point makeTurn(BoardState[][] board); |
There was a problem hiding this comment.
Правильней все-таки вместо массива сделать отдельный класс для всей доски.
Пока -1 за отсутствие инкапсуляции
| @FXML | ||
| private Text label; | ||
| @FXML | ||
| private Button button00; |
There was a problem hiding this comment.
Давайте попробуем избавиться от статично заданных кнопок и сделать так, чтобы было несложно изменить размер поля. Пока -0.5
| * @param column column of a turn | ||
| * @return winning player | ||
| */ | ||
| public PlayerType processTurn(int row, int column) { |
Owner
Author
There was a problem hiding this comment.
А почему private? Вроде это метод для общения с моделью снаружи. Говорим в модель, какой сделали ход, получаем ответ, кто выиграл
| */ | ||
| private boolean firstTurn = true; | ||
|
|
||
| private Random random = new Random(); |
| } else { | ||
| int row, column; | ||
| do { | ||
| row = Math.abs(random.nextInt()) % BOARD_SIZE; |
|
Красный билд на тревисе, -1 |
|
Ок, 10/10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.