Skip to content

feat: add configurable left black safety margin for YouTube cropping … #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djeada merged 2 commits into from
Sep 3, 2025
Merged

feat: add configurable left black safety margin for YouTube cropping … #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7efcb35
feat: add configurable left black safety margin for YouTube cropping …
djeada Sep 3, 2025
c964e6f
Update src/make_short.sh
djeada Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/make_short.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ Fit/Output:
stretch: force 1080x1920 (distorts)
cropfill: crop to fill 9:16 using centered math, then scale (no safety clamp)

Safety margin:
--safe-left N Left black margin in final 1080x1920 output (px). Default: 30. Use 0 to disable.

Encoding:
--fps N Output fps (default: 25)
--speed auto|X.Y Speed-up factor (default: auto = max(1.0, dur/59))
Expand Down Expand Up @@ -57,6 +60,7 @@ PRESET="veryfast"
PROBE_S="6"
EXACT_CROP="false"
DEBUG="false"
SAFE_LEFT="30"

# --- Parse args ---
while [[ $# -gt 0 ]]; do
Expand All @@ -75,6 +79,7 @@ while [[ $# -gt 0 ]]; do
--preset) PRESET="${2:-}"; shift 2 ;;
--probe-seconds) PROBE_S="${2:-}"; shift 2 ;;
--exact-crop) EXACT_CROP="${2:-false}"; shift 2 ;;
--safe-left) SAFE_LEFT="${2:-30}"; shift 2 ;;
--debug) DEBUG="true"; shift 1 ;;
-h|--help) usage ;;
*) echo "Unknown arg: $1"; usage ;;
Expand Down Expand Up @@ -180,6 +185,15 @@ IFS=',' read -r IW IH <<<"$(get_dims "$INPUT")"
vf_chain=()
CROP_SUFFIX=""; [[ "$EXACT_CROP" == "true" ]] && CROP_SUFFIX=":exact=1"

# Normalize and validate left safety margin for final canvas
SAFE_LEFT="$(clamp "${SAFE_LEFT}" 0 1078)"
SAFE_LEFT="$(floor_even "${SAFE_LEFT}")" # keep even for yuv420 alignment
TARGET_WIDTH=$(( 1080 - SAFE_LEFT ))
if (( TARGET_WIDTH < 2 )); then
echo "--safe-left too large; resulting width < 2"
exit 1
fi

case "$CROP_MODE" in
auto)
DET="$(autodetect_crop_whxy || true)"
Expand Down Expand Up @@ -222,6 +236,11 @@ case "$FIT" in
*) echo "Invalid --fit: $FIT"; exit 1 ;;
esac

# Overlay left black margin on the final 1080x1920 frame without distorting content
if (( SAFE_LEFT > 0 )); then
vf_chain+=("drawbox=x=0:y=0:w=${SAFE_LEFT}:h=ih:color=black:t=fill")
fi

# Pixel/Display aspect
vf_chain+=("setsar=1")
vf_chain+=("setdar=9/16")
Expand Down