-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add Fosstodon link to fundraising/thank-you.html #2298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi , |
|
Thanks! |
pauloxnet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have X we can add also Blue Sky
| @@ -0,0 +1,6 @@ | |||
| <p> | |||
| Follow us on | |||
| <a href="https://x.com/djangoproject">@djangoproject</a> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <a href="https://x.com/djangoproject">@djangoproject</a> | |
| <a href="https://x.com/djangoproject">@djangoproject on X</a> |
sarahboyce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend adding tests for changes, note that this test fails:
diff --git a/fundraising/tests/test_views.py b/fundraising/tests/test_views.py
index aca9d859..d272d32b 100644
--- a/fundraising/tests/test_views.py
+++ b/fundraising/tests/test_views.py
@@ -170,6 +170,8 @@ class TestThankYou(TestCase):
def test_template(self):
response = self.client.get(self.url)
self.assertTemplateUsed(response, "fundraising/thank-you.html")
+ self.assertContains(response, "Thank you for supporting the Django Project!")
+ self.assertContains(response, "@django on Fosstodon")I believe you have updated the wrong template and perhaps wanted to update djangoproject/templates/fundraising/thank-you.html
|
Hi , I updated the test cases as suggested. Now I'm trying to run the fundraising tests locally using SQLite, but I'm getting an error when the test database is created. Command I used: Error: If you have any suggestions or guidance on how to properly run fundraising tests with SQLite, I'd really appreciate your help. |
|
It might not be possible (or at least not easy) to test with SQLite as this project uses postgres. I use the docker setup following the instructions in the readme. Otherwise the readme instructions are suggesting setting up a postgres database |
|
Got it, thank you! |
Adds a Fosstodon link (https://fosstodon.org/@django
) alongside the existing X/Twitter link on the fundraising thank-you page.
Matches the current HTML structure and styling.
Verified rendering locally.