Synced webpages from sitemap to Document model for search. #2284
+469
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
force-pushed
the
sitemap-page-search
branch
2 times, most recently
from
17fef8d to
ca7b952
Compare
sarahboyce
force-pushed
the
sitemap-page-search
branch
from
ca7b952 to
7a42c1e
Compare
sarahboyce
commented
Oct 22, 2025
Comment on lines
+234
to
+237
| if force: | ||
| Document.objects.filter( | ||
| metadata__parents=DocumentationCategory.WEBSITE | ||
| ).delete() |
Contributor
Author
There was a problem hiding this comment.
In future we could add a last_modified field to Document and check the sitemap last modified and make updates according to this.
But for now, I think having a cron job to build the English dev docs with force (update_docs --force --language=en dev) running every 2 weeks (or even every month) will be good enough to update changes to the webiste pages for search and remove any stale pages. This content doesn't change very often, nor do we remove content often
sarahboyce
force-pushed
the
sitemap-page-search
branch
4 times, most recently
from
8020f62 to
3f4b174
Compare
sarahboyce
force-pushed
the
sitemap-page-search
branch
2 times, most recently
from
3bd8c81 to
1e4380b
Compare
sarahboyce
force-pushed
the
sitemap-page-search
branch
2 times, most recently
from
802b7f2 to
e791d7d
Compare
sarahboyce
force-pushed
the
sitemap-page-search
branch
2 times, most recently
from
af94b04 to
4fc09dc
Compare
sarahboyce
force-pushed
the
sitemap-page-search
branch
2 times, most recently
from
6d7606a to
9ddbe9c
Compare
sarahboyce
force-pushed
the
sitemap-page-search
branch
from
9ddbe9c to
1f1fc2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1499
This PR enables the whole website to be searched.
If anything is missing from the search, it is missing from a sitemap. Going forward we should make sure pages we want to be searched are included in our sitemaps.
For testing, recommend running
python manage.py update_docs --force --language=en devOn deployment we should run the first one with
--force. We may want to runpython manage.py update_docs --force --language=en dev(ie. english dev with force) on production every month to update existing searchable website content. Existing website content (static pages, old blog posts) are mostly static so we don't need to run with force very often