Skip to content

fix: Exclude captcha field from mail #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pierreben wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Exclude captcha field from mail #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9addd88
FEAT: Replace "trans" tags with "translate" in mail template
pierreben Nov 18, 2025
e21fd0b
FIX: Remove captcha field value from sent mail
pierreben Nov 18, 2025
b18616e
FEAT: Remove captcha_field value from FrontendForm cleaned_data
pierreben Nov 18, 2025
39fdd70
Revert "FIX: Remove captcha field value from sent mail"
pierreben Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion djangocms_form_builder/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ def clean(self):
raise ValidationError(
_("Please login before submitting this form."), code="unauthorized"
)
return super().clean()

cleaned_data = super().clean()
cleaned_data.pop("captcha_field", None)
return cleaned_data

def save(self):
results = {}
Expand Down
14 changes: 7 additions & 7 deletions djangocms_form_builder/templates/djangocms_form_builder/mails/default/mail_html.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{% load i18n %}
<h1>{% trans "Form submission" %}</h1>
<p>{% if user %}{% trans "by" %} {{ user.firstname }} {{ user.lastname }} ({{ user.username }}){% else %}{% trans "by anonymous" %}{% endif %}</p>
<h1>{% translate "Form submission" %}</h1>
<p>{% if user %}{% translate "by" %} {{ user.firstname }} {{ user.lastname }} ({{ user.username }}){% else %}{% translate "by anonymous" %}{% endif %}</p>
<table>
<thead>
<tr>
<th>{% trans "Field" %}</th>
<th>{% trans "Value" %}</th>
<th>{% translate "Field" %}</th>
<th>{% translate "Value" %}</th>
</tr>
</thead>
<tbody>
Expand All @@ -16,15 +16,15 @@ <h1>{% trans "Form submission" %}</h1>
</tr>
{% endfor %}
<tr>
<td>{% trans "time" %}</td>
<td>{% translate "time" %}</td>
<td>{% now "H:i d/m/Y" %}</td>
</tr>
<tr>
<td>{% trans "user agent" %}</td>
<td>{% translate "user agent" %}</td>
<td>{{ user_agent }}</td>
</tr>
<tr>
<td>{% trans "referer" %}</td>
<td>{% translate "referer" %}</td>
<td>{{ referer }}</td>
</tr>
</tbody>
Expand Down