Open
Conversation
yamamushi
commented
Jun 28, 2019
| params.OuterRadius = 1 | ||
| } | ||
| if params.ThetaSegments < 3 { | ||
| params.ThetaSegments = 3 |
Author
There was a problem hiding this comment.
Minimum is 3, but default is 8 in three.js, so I settled on a default of 3 here, this can be changed, but I didn't think it made a lot of sense to check for less than 3 and then default to 8 after that.
yamamushi
commented
Jun 28, 2019
| params.ThetaSegments = 3 | ||
| } | ||
| if params.PhiSegments < 1 { | ||
| params.PhiSegments = 1 |
Author
There was a problem hiding this comment.
Same as above for ThetaSegments, the three.js default is 8 with a minimum of 1, so I settled on default of 1 because it didn't make a lot of sense to check for less than 1 and then roll up to a default of 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add the Ring Geometry type as documented here:
https://threejs.org/docs/#api/en/geometries/RingGeometry
I have tested this shape as well using the basic example as a reference: https://i.imgur.com/RGNcOHS.gif
Please let me know if any additional formatting is needed for a happy PR 😊