Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Attempt to have fatal errors lead to the test process ending#653

Draft
Baccata wants to merge 1 commit into
mainfrom
attempt-to-surface-fatals
Draft

Attempt to have fatal errors lead to the test process ending#653
Baccata wants to merge 1 commit into
mainfrom
attempt-to-surface-fatals

Conversation

@Baccata

@Baccata Baccata commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Attempt at addressing https://github.com/disneystreaming/weaver-test/issues/651

Just a quick POC to see whether something can be done.

@kubukoz

kubukoz commented Apr 24, 2023

Copy link
Copy Markdown
Member

It seems to work fine when I run test, but in testOnly with just the weaver suite it still hangs. It can be cancelled with ctrl+C though.

@Baccata

Baccata commented Apr 24, 2023

Copy link
Copy Markdown
Contributor Author

but in testOnly with just the weaver suite it still hangs. It can be cancelled with ctrl+C though.

How did you test, out of curiosity ?

@kubukoz

kubukoz commented Apr 24, 2023

Copy link
Copy Markdown
Member

oof I thought I'd linked the full repro in the original ticket...

https://github.com/kubukoz/demos/tree/sbt-weaver-hang

  1. test (runs weaver, munit, scalatest)
  2. testOnly DemoTestWeaver

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants