Repository navigation
Conversation
The offline interpreter step runs `uv python install <ver>` with
UV_PYTHON_INSTALL_MIRROR pointing at the wheelhouse's python/ folder. uv
words that copy as a download ("Downloading cpython-…", "Downloaded
cpython-…"), runUv relayed it unchanged, and the setup window showed
"Downloading cpython-3.13.12-…" as its step, with the Download pill lit,
although nothing is downloaded.
The wheelhouse branch of setupEnv now announces the step as
"[env-setup] installing Python <ver> from the wheelhouse" and relays uv's
output through withoutPythonDownloadLines, which drops those two lines and
passes the rest ("Installed Python …"). It works on whole lines, holding a
chunk's unfinished last line until its end arrives or the step ends, so a
line split across chunks is still dropped whole. The online path keeps uv's
wording, which is true there.
Tests (pythonEnv.test.ts), on uv 0.13.4's real output for this step:
- the download lines are dropped and the rest kept;
- a download line split across chunks is dropped whole;
- an unfinished last line still reaches the stream at flush;
- through parseUvLine, the step reads "Installing Python 3.13.12 from the
wheelhouse" and no event is in the downloading phase.
With the filter disabled, the first, second and fourth fail (26 passed,
3 failed); all of them failed before the function existed.
Checks: npm run typecheck clean; npm run test:unit 179 passed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31.
In an offline install, the interpreter step is
uv python install <ver>withUV_PYTHON_INSTALL_MIRRORpointing at the wheelhouse'spython/folder. uv words that copy as a download, andrunUvrelayed its output unchanged. So the setup window showed "Downloading cpython-3.13.12-…" as its step, with the Download pill lit, although nothing is downloaded.Change (
js/main/pythonEnv.ts, the wheelhouse branch ofsetupEnvonly):[env-setup] installing Python <ver> from the wheelhouse, which the setup window shows as "Installing Python 3.13.12 from the wheelhouse".withoutPythonDownloadLines. It drops uv's "Downloading cpython-…" and "Downloaded cpython-…" lines and passes the rest, so the log keeps "Installed Python …".Tests (
pythonEnv.test.ts), on uv 0.13.4's real output for this step:parseUvLine, the step reads "Installing Python 3.13.12 from the wheelhouse", and no event is in the downloading phase.With the filter disabled, three of them fail: the first, second and fourth. All four failed before the function existed.
Checks:
npm run typecheck: clean.npm run test:unit: 179 passed.Not verified:
venv,export,pip install), as in the issue.The changelog fragment is
upcoming_changes/32.bugfix.rst, added in a second commit once the PR had its number, as #20 did.