Initial attempt at implementing a database approach to example users.#469
Draft
Initial attempt at implementing a database approach to example users.#469
Conversation
- Still need to improve tests - There is some repetition of data provided in view context - REQUIRES DATABASE MIGRATION
3 tasks
3 tasks
Collaborator
|
I haven't looked through this in detail. But a general comment is that this seems like a smart/flexible approach to take. But maybe for the Workshop, we should just hard-code this and not worry about the database at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relates to issues #466 and #454 to allow viewing example profiles.
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks
Outstanding tasks