Open
Conversation
|
The comment above is the only thing we need to resolve. Otherwise the last 3 commits are good. |
|
Whether this should be merged or now depends on whether the Ding.Team perceives this as a problem and what is considered an appropriate solution. |
This to ensure the access denied page does not leak information.
Now, everyone else gets access denied.
Member
Author
|
Rebased on master 🍴 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained on Skype.
This PR depends on PR #27, so the first three commits on this branch should be ignored.