Skip to content

fix(rdma): retain activated pooled endpoint - #310

Merged
ketor merged 1 commit into
dingodb:mainfrom
ketor:feat/rdma-retire-drain-hotfix
Aug 11, 2026
Merged

fix(rdma): retain activated pooled endpoint#310
ketor merged 1 commit into
dingodb:mainfrom
ketor:feat/rdma-retire-drain-hotfix

Conversation

@ketor

@ketor ketor commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Problem

PR #309 activated an idle endpoint but erased it without assigning it to the caller. Every cache hit leaked the endpoint and its process-wide budget, forcing fresh QPs and eventually bounded waits.

Fix

Assign the activated endpoint before removing it from the idle pool.

Verification

  • local lifecycle tests: 3/3 PASS
  • local RDMA safety tests: 3 PASS, 1 hardware-dependent skip
  • 0064 exact regression: broken PR fix(rdma): isolate idle endpoints before draining #309 cold C32 makespan 36.13s; fixed commit 9.33s
  • 0064 fixed warm C32: 5.00s vs pre-governance baseline 5.61s
  • 0064 fixed cold C32: 9.33s vs pre-governance baseline 9.64s
  • fixed candidate remained healthy with no fatal/error log matches

@ketor
ketor force-pushed the feat/rdma-retire-drain-hotfix branch from 8a29f95 to 5ae380f Compare August 11, 2026 03:37
@ketor
ketor added this pull request to the merge queue Aug 11, 2026
Merged via the queue into dingodb:main with commit 0f5c1dc Aug 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant