ateom-microvm: give the micro-VM guest DNS so name-based egress works#1
Closed
dims wants to merge 1 commit into
Closed
ateom-microvm: give the micro-VM guest DNS so name-based egress works#1dims wants to merge 1 commit into
dims wants to merge 1 commit into
Conversation
The guest got an interface, default route, and host NAT but no /etc/resolv.conf: ateom-microvm drops atelet's resolv.conf bind (a host bind is meaningless inside a VM) and never sends CreateSandbox.Dns, so the guest could reach IPs but not resolve names. Workloads doing name-based egress (e.g. the OpenShell helpdesk agent calling Ollama Cloud) failed; only no-egress paths like /status worked. Write /etc/resolv.conf into the bundle rootfs before mkfs.ext4 in both the golden-boot (RunWorkload) and restore (RestoreWorkload) paths, copied verbatim from the worker pod's own resolv.conf (cluster DNS) -- the same source the kata shim's getDNS uses -- with a public-resolver guard only for a degenerate empty file. Mirrors what the kata shim achieves and satisfies kata-agent's requirement that /etc/resolv.conf pre-exist. Verified on bigbox: helpdesk-microvm /chat returns real gpt-oss:20b-cloud completions and survives suspend/resume; counter-microvm and /status unaffected.
Owner
Author
|
Superseding with a single-commit PR against upstream agent-substrate/substrate:main (PR agent-substrate#287 is merged, so this rebases cleanly onto main). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A micro-VM (
ateom-microvm) actor gets a guest interface, default route, and host NAT, but no/etc/resolv.conf: ateom-microvm drops atelet's resolv.conf bind (a host bind is meaningless inside a VM) and never sendsCreateSandbox.Dns. The guest can reach IPs but not resolve names, so workloads doing name-based egress — e.g. the OpenShell helpdesk agent calling Ollama Cloud (/chat) — fail; only no-egress paths like/statuswork.Fix
Write
/etc/resolv.confinto the bundle rootfs beforemkfs.ext4, in both the golden-boot (RunWorkload) and restore (RestoreWorkload) paths, copied verbatim from the worker pod's own resolv.conf (cluster DNS) — the same source the kata shim'sgetDNSuses — with a public-resolver guard only for a degenerate empty file. Also satisfies kata-agent's requirement that/etc/resolv.confalready exist.Validation (kind on a KVM host)
/chatreturns realgpt-oss:20b-cloudcompletions and survives suspend/resume (chat history preserved)./statusunaffected.Stacks on
fix/microvm-large-rootfs(the large-image mkfs fix is required for the ~3 GB helpdesk rootfs), so the base is set there to keep this to the single DNS change.