perf(main): serialize remap updates and trim calc hot-path allocs#73
Draft
seanjnkns wants to merge 1 commit into
Draft
perf(main): serialize remap updates and trim calc hot-path allocs#73seanjnkns wants to merge 1 commit into
seanjnkns wants to merge 1 commit into
Conversation
Apply tryRemap from a single goroutine in calcPgMappingsToUndoBackfill to avoid concurrent mapping state lock contention. Cache crush tree lookups in getCandidateMappings and reduce per-iteration string parsing and slicing. Benchmarks (large fixtures, benchstat vs scaffold baseline): CalcPgMappingsToUndoBackfill ~35% faster, 62.8→32.6 MiB B/op, 1.05M→636k allocs/op CalcPgMappingsToDrainOsd ~73% faster, 81.1→42.8 MiB B/op, 1.21M→606k allocs/op CalcPgMappingsToBalanceOsds ~21% faster, 52.7→29.4 MiB B/op, 834k→593k allocs/op GenerateCrushChangeMappings ~68% faster, 31.7→19.0 MiB B/op, 263k→197k allocs/op
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply tryRemap from a single goroutine in calcPgMappingsToUndoBackfill to avoid concurrent mapping state lock contention. Cache crush tree lookups in getCandidateMappings and reduce per-iteration string parsing and slicing.
Benchmarks (large fixtures, benchstat vs scaffold baseline):
CalcPgMappingsToUndoBackfill ~35% faster, 62.8→32.6 MiB B/op, 1.05M→636k allocs/op
CalcPgMappingsToDrainOsd ~73% faster, 81.1→42.8 MiB B/op, 1.21M→606k allocs/op
CalcPgMappingsToBalanceOsds ~21% faster, 52.7→29.4 MiB B/op, 834k→593k allocs/op
GenerateCrushChangeMappings ~68% faster, 31.7→19.0 MiB B/op, 263k→197k allocs/op