perf(ceph): cut allocations on parsing and ceph JSON hot paths#72
Draft
seanjnkns wants to merge 1 commit into
Draft
perf(ceph): cut allocations on parsing and ceph JSON hot paths#72seanjnkns wants to merge 1 commit into
seanjnkns wants to merge 1 commit into
Conversation
Cache erasure-coded pool flags and pg upmap items keyed off osd dump. Parse PG IDs and crushdiff lines without per-call regex or strings.Fields storms. Guard handleCephInf so bytes.Replace runs only when input contains "inf". Benchmarks (large fixtures, benchstat vs scaffold baseline): ImportMappingsLoop ~280x faster, 27.4 GiB→31.3 MiB B/op, 3.97M→617k allocs/op ExportMappings ~300x faster, 27.4 GiB→31.6 MiB B/op, 3.95M→615k allocs/op ParseCrushDiff ~59% faster, 29.2→16.5 MiB B/op, 263k→197k allocs/op MustGetCurrentMappingState ~29% faster, 52.7→29.4 MiB B/op, 833k→593k allocs/op
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache erasure-coded pool flags and pg upmap items keyed off osd dump. Parse PG IDs and crushdiff lines without per-call regex or strings.Fields storms. Guard handleCephInf so bytes.Replace runs only when input contains "inf".
Benchmarks (large fixtures, benchstat vs scaffold baseline):
ImportMappingsLoop ~280x faster, 27.4 GiB→31.3 MiB B/op, 3.97M→617k allocs/op
ExportMappings ~300x faster, 27.4 GiB→31.6 MiB B/op, 3.95M→615k allocs/op
ParseCrushDiff ~59% faster, 29.2→16.5 MiB B/op, 263k→197k allocs/op
MustGetCurrentMappingState ~29% faster, 52.7→29.4 MiB B/op, 833k→593k allocs/op