Skip to content

Support camera access in the create-credential auth WebView #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nesfeder-proof wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support camera access in the create-credential auth WebView #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
</intent-filter>
</activity>
</application>
<uses-permission android:name="android.permission.CAMERA" />
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.USE_BIOMETRIC" />
</manifest>
49 changes: 49 additions & 0 deletions app/src/main/java/com/credman/cmwallet/createcred/CreateCredentialActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,21 @@
package com.credman.cmwallet.createcred

import android.Manifest
import android.content.Intent
import android.content.pm.PackageManager
import android.os.Build
import android.os.Bundle
import android.service.credentials.CredentialProviderService
import android.util.Log
import android.view.ViewGroup
import android.webkit.PermissionRequest
import android.webkit.WebChromeClient
import android.webkit.WebResourceRequest
import android.webkit.WebView
import android.webkit.WebViewClient
import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.activity.result.contract.ActivityResultContracts
import androidx.activity.viewModels
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
Expand Down Expand Up @@ -62,6 +67,21 @@ import com.credman.cmwallet.ui.theme.CMWalletTheme
class CreateCredentialActivity : ComponentActivity() {
private val viewModel: CreateCredentialViewModel by viewModels()

private val pendingWebPermissionRequests = mutableListOf<PermissionRequest>()

private val cameraPermissionLauncher = registerForActivityResult(
ActivityResultContracts.RequestPermission()
) { granted ->
pendingWebPermissionRequests.forEach { request ->
if (granted) {
request.grant(arrayOf(PermissionRequest.RESOURCE_VIDEO_CAPTURE))
} else {
request.deny()
}
}
pendingWebPermissionRequests.clear()
}

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
if (savedInstanceState == null) {
Expand Down Expand Up @@ -301,6 +321,35 @@ class CreateCredentialActivity : ComponentActivity() {
ViewGroup.LayoutParams.MATCH_PARENT,
ViewGroup.LayoutParams.WRAP_CONTENT
)
this.webChromeClient = object : WebChromeClient() {
override fun onPermissionRequest(request: PermissionRequest) {
val pageWantsCamera =
PermissionRequest.RESOURCE_VIDEO_CAPTURE in request.resources
val appHoldsCameraPermission = checkSelfPermission(
Manifest.permission.CAMERA
) == PackageManager.PERMISSION_GRANTED
val permissionDialogAlreadyShowing =
pendingWebPermissionRequests.isNotEmpty()

when {
!pageWantsCamera -> {
Log.d(TAG, "[AuthWebView] Denying ${request.resources.joinToString()} for ${request.origin}")
request.deny()
}
appHoldsCameraPermission -> {
Log.d(TAG, "[AuthWebView] Granting camera to ${request.origin}")
request.grant(arrayOf(PermissionRequest.RESOURCE_VIDEO_CAPTURE))
}
else -> {
Log.d(TAG, "[AuthWebView] Asking for camera permission on behalf of ${request.origin}")
pendingWebPermissionRequests += request
if (!permissionDialogAlreadyShowing) {
cameraPermissionLauncher.launch(Manifest.permission.CAMERA)
}
}
}
}
}
this.webViewClient = object : WebViewClient() {
override fun shouldOverrideUrlLoading(
view: WebView?,
Expand Down