Skip to content

Add TypeDirectedDocumentLoader for type-based document loading - #304

Open
anatoly-scherbakov wants to merge 7 commits into
masterfrom
choice-by-type-document-loader
Open

Add TypeDirectedDocumentLoader for type-based document loading#304
anatoly-scherbakov wants to merge 7 commits into
masterfrom
choice-by-type-document-loader

Conversation

@anatoly-scherbakov

@anatoly-scherbakov anatoly-scherbakov commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add ChoiceByTypeDocumentLoader to dispatch by Python input type (pathlib.Path vs URL str).
  • Document and export the loader; compose with ChoiceBySchemeDocumentLoader for URL schemes.

Stack

master#301 File → #302 Scheme → #304 ByType (this PR) → #303 Sqlite lazy-init → #305 CLI.

Test plan

  • pytest tests/test_choice_by_type_document_loader.py tests/test_choice_by_scheme_document_loader.py
  • CI green

@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown

@anatoly-scherbakov
anatoly-scherbakov force-pushed the choice-by-type-document-loader branch from ac89a95 to e619f5a Compare August 10, 2026 18:34
Base automatically changed from choice-by-scheme-document-loader to master August 19, 2026 20:28
@anatoly-scherbakov
anatoly-scherbakov force-pushed the choice-by-type-document-loader branch from e619f5a to f84b560 Compare August 19, 2026 20:53
@anatoly-scherbakov

Copy link
Copy Markdown
Collaborator Author

Renamed to TypeDirectedDocumentLoader to match the previous one cc @mielvds

@anatoly-scherbakov anatoly-scherbakov changed the title Add ChoiceByTypeDocumentLoader for type-based document loading Add TypeDirectedDocumentLoader for type-based document loading Aug 19, 2026

@mielvds mielvds left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Just some small requests ;)

Comment thread docs/examples/document_loaders/type_directed.py
Comment thread docs/reference/document-loaders/type-directed.md Outdated
Comment thread lib/pyld/jsonld.py Outdated
Comment thread tests/test_type_directed_document_loader.py
@anatoly-scherbakov
anatoly-scherbakov force-pushed the choice-by-type-document-loader branch 2 times, most recently from 0f82a83 to f15cac7 Compare August 21, 2026 17:38
@anatoly-scherbakov
anatoly-scherbakov force-pushed the choice-by-type-document-loader branch from f15cac7 to 92bef86 Compare August 21, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants