Repository navigation
refactor: adjust the internal interface and workflow for better agent performance - #48
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 98.24% 99.68% +1.44%
==========================================
Files 8 8
Lines 626 634 +8
==========================================
+ Hits 615 632 +17
+ Misses 11 2 -9
🚀 New features to boost your workflow:
|
ycexiao
marked this pull request as ready for review
October 15, 2026 20:11
Contributor
Author
|
@sbillinge, it's ready for review. |
ycexiao
marked this pull request as draft
October 16, 2026 00:34
Contributor
Author
|
converted to draft as new issues founded. |
Contributor
Author
|
|
ycexiao
marked this pull request as ready for review
October 16, 2026 04:22
Contributor
Author
|
@sbillinge, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refinebaseasparametric_refinementWhat problem does this PR address?
I asked
Claudein the conversation where it manages to reproduce publication results this question "List the situations when diffpy.apps is not working as expected so I can fix".It pumped 10 points. Three of these behaviors are expected, the rest is fixed by small refactoring in this PR:
What should the reviewer(s) do?