shortenFullyQualifiedTypes: preserve unqualified type resolution - #3037
Open
maxandersen wants to merge 1 commit into
Open
shortenFullyQualifiedTypes: preserve unqualified type resolution#3037maxandersen wants to merge 1 commit into
maxandersen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3033.
When a compilation unit already uses an unqualified type name, adding an import
for a different fully qualified type with the same simple name can change what
the existing reference resolves to.
Collect unqualified type references and leave conflicting fully qualified
references unchanged, unless the target type is already explicitly or
implicitly imported.
Adds a regression test for a same-package
RandomAccessFileextended by aclass that also references
java.io.RandomAccessFile.Tests
./gradlew :testlib:test --tests com.diffplug.spotless.java.ShortenFullyQualifiedTypesStepTest./gradlew spotlessCheck