Repository navigation
Apply security headers to Workers auth error responses - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The successful security audit found that failures outside the inner auth app returned a 503 with only
Cache-Control: no-store. For example, an HTTPAPP_ORIGINor a throwing email factory omitted the referrer policy, content-type protection, frame protection, and CSP. The diagnostics wrapper's fallback had the same gap.Extract the existing auth security-header middleware and apply it to the outer Worker app as well. This covers setup and teardown failures and diagnostics-generated responses with the same policy used by normal auth responses. Update
SECURITY.mdto explicitly include these fallback responses.Validation:
git diff --checkpassed.