Skip to content

docs(vscode): list the four missing modules in the extension-host file map#246

Open
dormouse-bot wants to merge 1 commit into
mainfrom
docs/vscode-spec-file-map
Open

docs(vscode): list the four missing modules in the extension-host file map#246
dormouse-bot wants to merge 1 commit into
mainfrom
docs/vscode-spec-file-map

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

Surfaced by the nightly code-quality survey.

The extension-host architecture tree in docs/specs/vscode.md lists 9 files but vscode-ext/src/ currently holds four more that the tree omitted:

  • workspace-chrome.ts — already cited later in the same spec as the source of truth for workspaceTitle/workspaceBadge.
  • shell-selection.ts — backs the spec's "Shell selection" section.
  • agent-browser-host.ts — extension-host wiring + stream relay (closePoppedOutSessions, used in deactivate).
  • iframe-proxy-host.ts — VS Code binding for the iframe transparent proxy.

A reader using the tree as the file→responsibility map wouldn't find these modules. This adds them so the map matches the directory. Docs-only; pnpm lint:specs passes.

…e map

The vscode.md architecture tree omitted workspace-chrome.ts, shell-selection.ts,
agent-browser-host.ts, and iframe-proxy-host.ts — all present in vscode-ext/src/
and referenced elsewhere in the same spec (workspace-chrome as source of truth
for workspaceTitle/workspaceBadge; the shell-selection section; closePoppedOutSessions
in deactivate). Add them so the tree is an accurate file->responsibility map.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6701ec8
Status: ✅  Deploy successful!
Preview URL: https://14dc00e3.mouseterm.pages.dev
Branch Preview URL: https://docs-vscode-spec-file-map.mouseterm.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant