docs: drop stale frame-refusal comments after the iframe-proxy rework#243
Open
dormouse-bot wants to merge 1 commit into
Open
docs: drop stale frame-refusal comments after the iframe-proxy rework#243dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
2d9ac80
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6f344874.mouseterm.pages.dev |
| Branch Preview URL: | https://docs-comment-drift-post-brow.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-drift cleanup surfaced by the nightly review of the last 24h of merges (the dor browser-open / iframe-proxy rework, #241).
lib/src/host/iframe-proxy.tsandlib/src/components/wall/IframePanel.tsx— both doc comments still claimed reachability and frame-refusal surface as served error pages. Frame-refusal handling was removed in Resolve dor browser-open targets and loosen the iframe proxy #241 (frameRefusedPage/refusesFramingare gone; any http upstream is now framed), so the comments described behavior that no longer exists. Dropped the frame-refusal clause; the SSRF admission guard and reachability error page are unchanged.lib/src/components/wall/use-dor-control.ts— theuseDorControlJSDoc had one line indented three extra spaces, breaking the*alignment of the block comment. Reindented.Comment-only changes — no behavior change, so no regression test. Verified there are no remaining
frame-refusal/frameRefused/refusesFramingreferences anywhere underlib/ordocs/.