Skip to content

Wait for terminal content before selecting in stories - #1317

Merged
nedtwigg merged 1 commit into
mainfrom
audit-selection-story-readiness
Oct 21, 2026
Merged

nedtwigg merged 1 commit into
mainfrom
audit-selection-story-readiness

Conversation

@nedtwigg

Copy link
Copy Markdown
Member

Selection stories could apply their selection to a measured but still empty terminal. Later output invalidated it, leaving a missing overlay or copy editor. A WebKit Argos capture showed the copy-editor story without its selection or editor.

Wait for preview priming and terminal content as well as grid dimensions, sharing the existing terminal-content predicate. Require the copy editor to be visible before capturing its stories, so an expired wait cannot silently snapshot the closed state.

Validation: delayed-content and delayed-priming regressions fail before the fix and pass after it; teardown cancels the wait. All 64 focused story/CopyEditor tests and library TypeScript pass. The live Prose And Code story displays its selection and editor in the Dormouse browser pane.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: eef4711
Status: ✅  Deploy successful!
Preview URL: https://9238eea3.mouseterm.pages.dev
Branch Preview URL: https://audit-selection-story-readin.mouseterm.pages.dev

View logs

@nedtwigg
nedtwigg merged commit d68cc93 into main Oct 21, 2026
18 of 19 checks passed
@nedtwigg
nedtwigg deleted the audit-selection-story-readiness branch October 21, 2026 17:21

This branch was successfully deployed

No deployments
hosted-preview — eef47116 Deployed Oct 21, 2026 by nedtwigg via deploy #1802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants