Skip to content

Keep one-time Settings state tied to its latest action - #1311

Merged
nedtwigg merged 1 commit into
mainfrom
audit-one-time-panel-actions
Oct 21, 2026
Merged

nedtwigg merged 1 commit into
mainfrom
audit-one-time-panel-actions

Conversation

@nedtwigg

Copy link
Copy Markdown
Member

After cancelling a one-time link request, a late failure still appeared in Settings. If the user started another request first, the old request's completion could also clear the new busy state and hide its spinner.

Only the latest panel action may update its busy or error state. The shared one-time store continues to own connection state.

Validation: all three new cancellation/retry regressions failed before the fix. 123 Settings, indicator, and store tests pass, along with library TypeScript, spec lint, Markdown lint, and diff checks.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 13967c9
Status: ✅  Deploy successful!
Preview URL: https://18675ee4.mouseterm.pages.dev
Branch Preview URL: https://audit-one-time-panel-actions.mouseterm.pages.dev

View logs

@nedtwigg
nedtwigg merged commit 4a0de03 into main Oct 21, 2026
18 of 19 checks passed
@nedtwigg
nedtwigg deleted the audit-one-time-panel-actions branch October 21, 2026 17:30

This branch was successfully deployed

No deployments
hosted-preview — 13967c9b Deployed Oct 21, 2026 by nedtwigg via deploy #1795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants