Skip to content

[feat]support rn asyncCommonSubpackage - #2575

Open
CommanderXL wants to merge 3 commits into
masterfrom
feat-rn-asyncCommonSubpackage
Open

[feat]support rn asyncCommonSubpackage#2575
CommanderXL wants to merge 3 commits into
masterfrom
feat-rn-asyncCommonSubpackage

Conversation

@CommanderXL

Copy link
Copy Markdown
Member

No description provided.

Comment thread packages/webpack-plugin/lib/index.js Outdated
options.forceMainPackageRules = options.forceMainPackageRules || {}
options.forceProxyEventRules = options.forceProxyEventRules || {}
options.disableRequireAsync = options.disableRequireAsync || false
options.asyncCommonSubpackage = options.asyncCommonSubpackage !== undefined ? options.asyncCommonSubpackage : true

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个在webConfiig和rnConfig中分包新增一个同名配置分别控制吧

Comment thread packages/webpack-plugin/lib/index.js Outdated
@@ -1308,8 +1309,8 @@ class MpxWebpackPlugin {
}
if (!hasOwn(splitChunksOptions.cacheGroups, 'async')) {
splitChunksOptions.cacheGroups.async = {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个cacheGroup在不是async-common的情况下,命名也改一下吧,还叫async有点奇怪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants