fix(posting): mark removed split parts for reclamation - #9825
Open
KeisukeYamashita wants to merge 1 commit into
Open
fix(posting): mark removed split parts for reclamation#9825KeisukeYamashita wants to merge 1 commit into
KeisukeYamashita wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #9824
Description
Write
BitEmptyPostingrecords for split parts removed during rollup, allowing Badger compaction to reclaim their old payloads.Use the replacement parent's timestamp, including the
+1for finite read timestamps, to preserve historical reads.Add regression tests covering:
Validation: the posting test suite, targeted race tests (three runs), targeted debug tests, and Dgraph build pass. Trunk has not yet been run.
This change does not remove empty-key metadata or retroactively clean up already-orphaned parts.
Checklist
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.