perf(query): faster valToBytes for UidID and PasswordID#9720
Open
shaunpatterson wants to merge 1 commit into
Open
perf(query): faster valToBytes for UidID and PasswordID#9720shaunpatterson wants to merge 1 commit into
shaunpatterson wants to merge 1 commit into
Conversation
UidID: build "0x"+hex via strconv.AppendUint into a pre-sized buffer instead of
fmt.Sprintf("%#x") (output verified byte-identical, including uid=0 and max
uint64); keeps a type-assert fallback. PasswordID: use stringJsonMarshal instead
of fmt.Sprintf("%q") -- faster and produces proper JSON string escaping.
BenchmarkValToBytes:
Uid: 52n -> 18n (-65%), 2 allocs -> 1
Password: 126n -> 35n (-73%), 3 allocs -> 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UidID: build
"0x"+hexviastrconv.AppendUintinto a pre-sized buffer instead offmt.Sprintf("%#x")(output verified byte-identical incl. uid=0 and max uint64; keeps a type-assert fallback). PasswordID: usestringJsonMarshalinstead offmt.Sprintf("%q")— faster and produces proper JSON string escaping.BenchmarkValToBytes: Uid 52n→18n (-65%, 2→1 allocs); Password 126n→35n (-73%, 3→1 allocs).Independent change; branched from
4b9b399d. Verified: package unit tests pass + Go benchmark (benchstat, p<0.01). Single-thread microbenchmarks; not yet run through the Docker integration suite.