perf(query): pool encoder scaffolding across requests#9719
Open
shaunpatterson wants to merge 1 commit into
Open
perf(query): pool encoder scaffolding across requests#9719shaunpatterson wants to merge 1 commit into
shaunpatterson wants to merge 1 commit into
Conversation
Reuse the encoder struct + attrMap + idSlice via a sync.Pool, cleared by free() in toFastJSON's defer. buf is deliberately NOT pooled and is allocated fresh per request: toFastJSON returns enc.buf.Bytes() (a slice aliasing buf's backing array) to its caller after the encoder is freed, so pooling buf would let a concurrent request overwrite an in-flight response. BenchmarkEncoderLifecycle: allocs/op 10 -> 4 (-60%), time -14%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the encoder struct +
attrMap+idSlicevia async.Pool, cleared byfree()intoFastJSON's defer.bufis deliberately not pooled and is allocated fresh per request:toFastJSONreturnsenc.buf.Bytes()(a slice aliasing buf's backing array) to its caller after the encoder is freed, so pooling buf would let a concurrent request overwrite an in-flight response.BenchmarkEncoderLifecycle: allocs/op 10→4 (-60%), time -14%.Independent change; branched from
4b9b399d. Verified: package unit tests pass + Go benchmark (benchstat, p<0.01). Single-thread microbenchmarks; not yet run through the Docker integration suite.