Skip to content

chore(core): use unsafe.Slice instead of deprecated reflect.SliceHeader #9550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xqqp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(core): use unsafe.Slice instead of deprecated reflect.SliceHeader #9550

xqqp wants to merge 1 commit into from

Conversation

@xqqp
Copy link
Contributor

@xqqp xqqp commented Jan 3, 2026 •
edited
Loading

Description

  • reflect.SliceHeader has been deprecated. This PR uses unsafe.Slice instead, as recommended by the documentation
  • Removed type hints when calling generic functions
  • removed the floatBits argument from dotProductT(), because it was unused
  • added a test for BytesAsFloatArray() that validates that the conversion works

@xqqp xqqp requested a review from a team as a code owner January 3, 2026 14:08
@xqqp
Copy link
Contributor Author

xqqp commented Jan 5, 2026

@matthewmcneely there are two functions named BytesAsFloatArray, one in index/helper.go and the other in types/value.go. Both functions convert a byte slice into a float slice. What do you think about refactoring the code so we only have one function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xqqp