feat: add strikethrough support for <del> tag#59
Open
arthrod wants to merge 2 commits intodfop02:release/1.1.4from
Open
feat: add strikethrough support for <del> tag#59arthrod wants to merge 2 commits intodfop02:release/1.1.4from
arthrod wants to merge 2 commits intodfop02:release/1.1.4from
Conversation
Refactor HTML-to-DOCX with centralized styles and test coverage
The <del> HTML element represents text that has been deleted from a document. Like the existing <s> tag support, this maps to the font.strike property in python-docx. This is consistent with HTML semantics where both <del> and <s> represent struck-through text.
Owner
|
This PR is fine, please just include the new |
dfop02
added
New Feature
Owner
|
hey @arthrod , Just a kindly reminder. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<del>HTML element<del>tofont.strike = True, same as existing<s>tag supportBackground
The
<del>HTML element represents text that has been deleted from a document. While<s>is already supported for strikethrough,<del>was missing. Both tags semantically represent struck-through text per HTML specification.Example:
Changes
'del': 'strike'toFONT_STYLESin constants.pyTest plan
<del>text</del>renders with strikethrough<s>tag still works<del><strong>text</strong></del>)