Use wrapping exceptions to fix truncated stack traces#121
Open
m-dzianishchyts wants to merge 1 commit intodflib:mainfrom
Open
Use wrapping exceptions to fix truncated stack traces#121m-dzianishchyts wants to merge 1 commit intodflib:mainfrom
m-dzianishchyts wants to merge 1 commit intodflib:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #118.
Details
The root cause is that JShell's
UserExceptionclass doesn't preserve theThrowable causefield during serialization, it only carriesmessage,causeExceptionClass, andstackTraceelements. When the exception chain is converted toEvalExceptionby JShell, intermediate causes are discarded.We can recursively wrap the entire exception cause chain in
UserException's usinginitCause()before passing to JShell. This allows JShell to properly reconstruct the full exception chain.Testing
Tested manually in jupyter notebook with a test snippet. Full exception chain is now displayed.