Skip to content

Fix all parameter type hints#22

Open
meck-gd wants to merge 1 commit intodfir-iris:masterfrom
GDATAAdvancedAnalytics:typing-fixes
Open

Fix all parameter type hints#22
meck-gd wants to merge 1 commit intodfir-iris:masterfrom
GDATAAdvancedAnalytics:typing-fixes

Conversation

@meck-gd
Copy link
Copy Markdown

@meck-gd meck-gd commented Apr 23, 2026

  • Type hints such as myparam: [int, str] are invalid. They were meant to be unions, so I changed them to int | str.
  • Type hints such as myparam: int = None are also invalid; if you want to have None defaults, you'll have to be explicit and allow None as a type. Some type checkers won't flag the method definition, but if you'd like to pass all possible parameters at a call site and pass None, you'll be flagged with no way of fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant