refactor: store nodes as Rc in cache by maksymar · Pull Request #429 · dfinity/stable-structures

maksymar · 2026-04-02T13:03:35Z

No description provided.

github-actions · 2026-04-02T13:27:26Z

`canbench` 🏋 (dir: ./benchmarks/vec) `30950fc` 2026-04-02 13:35:45 UTC

✅ ./benchmarks/vec/canbench_results.yml is up to date
📦 canbench_results_vec.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2026-04-02T13:27:26Z

`canbench` 🏋 (dir: ./benchmarks/btreemap) `30950fc` 2026-04-02 13:37:17 UTC

✅ ./benchmarks/btreemap/canbench_results.yml is up to date
📦 canbench_results_btreemap.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   Regressions and improvements 🔴🟢
    counts:   [total 252 | regressed 20 | improved 19 | new 0 | unchanged 213]
    change:   [max +323.28M | p75 +2.05M | median -194.56K | p25 -2.58M | min -64.27M]
    change %: [max +64.84% | p75 +0.48% | median -0.08% | p25 -0.50% | min -64.07%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 252 | regressed 0 | improved 0 | new 0 | unchanged 252]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 252 | regressed 0 | improved 0 | new 0 | unchanged 252]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------

Only significant changes:
| status | name                                                  | calls |     ins |  ins Δ% | HI |  HI Δ% | SMI |  SMI Δ% |
|--------|-------------------------------------------------------|-------|---------|---------|----|--------|-----|---------|
|   +    | btreemap_v2_last_key_value_u64_u64                    |       | 133.84M | +64.84% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_100k_u64_u64_nocache                  |       |   3.15B | +11.44% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_range_count_20_10mib                      |       |  20.57M | +11.35% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_range_key_sum_20_10mib                    |       |  20.57M | +11.35% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_miss_u64_u64_nocache                  |       | 257.41M |  +9.36% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_zipf_10k_u64_u64_nocache              |       | 246.73M |  +8.69% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_zipf_100k_u64_u64_nocache             |       |   2.98B |  +8.60% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_mixed_get_insert_zipf_10k_u64_u64_nocache |       | 598.44M |  +5.26% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_then_insert_u64_u64_nocache           |       | 621.72M |  +4.56% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_peek_then_pop_last_u64_u64_nocache        |       | 893.40M |  +3.42% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_then_remove_u64_u64_nocache           |       | 812.78M |  +2.87% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_u64_blob8                             |       | 199.34M |  +2.76% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_blob_32_1024                          |       | 300.55M |  +2.68% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_contains_blob_32_1024                     |       | 288.15M |  +2.60% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_100k_u64_u64                          |       |   2.38B |  +2.47% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_contains_then_remove_u64_u64_nocache      |       | 805.04M |  +2.47% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_vec_64_128                            |       | 412.56M |  +2.42% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_zipf_100k_u64_u64                     |       |   2.03B |  +2.21% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_blob_32_0                             |       | 294.93M |  +2.20% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_contains_blob_32_0                        |       | 293.16M |  +2.19% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_remove_vec_32_16                          |       | 856.47M |  -2.04% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_first_key_value_blob_32_1024              |       | 242.09M |  -5.07% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_get_zipf_heavy_10k_u64_u64                |       |  80.49M |  -7.99% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_last_key_value_blob_32_128                |       | 107.83M | -11.87% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_last_key_value_blob_32_1024               |       | 148.88M | -11.88% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_first_key_value_blob_32_0                 |       |  87.57M | -12.87% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_first_key_value_blob_32_128               |       |  92.22M | -13.17% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_first_key_value_u64_u64                   |       |  73.69M | -13.20% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_last_key_value_vec_32_128                 |       |  61.52M | -16.03% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_last_key_value_vec_32_vec128              |       |  61.52M | -16.03% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_first_key_value_blob_256_128              |       | 295.67M | -16.14% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_first_key_value_blob_8_128                |       |  36.74M | -34.03% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_last_key_value_blob_8_128                 |       |  33.90M | -35.87% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_last_key_value_blob_256_128               |       |  86.44M | -42.64% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_first_key_value_vec_32_128                |       |  19.69M | -49.07% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_first_key_value_vec_32_vec128             |       |  19.69M | -49.07% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_last_key_value_blob_32_0                  |       |  12.40M | -61.89% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_last_key_value_principal                  |       |  11.86M | -63.00% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_first_key_value_principal                 |       |  11.33M | -64.07% |  0 |  0.00% |   0 |   0.00% |

ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2026-04-02T13:27:26Z

`canbench` 🏋 (dir: ./benchmarks/io_chunks) `30950fc` 2026-04-02 13:36:41 UTC

✅ ./benchmarks/io_chunks/canbench_results.yml is up to date
📦 canbench_results_io_chunks.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   Improvements detected 🟢
    counts:   [total 18 | regressed 0 | improved 1 | new 0 | unchanged 17]
    change:   [max +399.03M | p75 0 | median 0 | p25 0 | min -1.08B]
    change %: [max +1.99% | p75 0.00% | median 0.00% | p25 0.00% | min -6.09%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 18 | regressed 0 | improved 0 | new 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 18 | regressed 0 | improved 0 | new 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------

Only significant changes:
| status | name                    | calls |    ins |  ins Δ% | HI |  HI Δ% | SMI |  SMI Δ% |
|--------|-------------------------|-------|--------|---------|----|--------|-----|---------|
|   -    | read_chunks_btreemap_1m |       | 16.72B |  -6.09% |  0 |  0.00% |   0 |   0.00% |

ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2026-04-02T13:27:26Z

`canbench` 🏋 (dir: ./benchmarks/memory_manager) `30950fc` 2026-04-02 13:35:43 UTC

✅ ./benchmarks/memory_manager/canbench_results.yml is up to date
📦 canbench_results_memory-manager.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2026-04-02T13:27:27Z

`canbench` 🏋 (dir: ./benchmarks/nns) `30950fc` 2026-04-02 13:35:59 UTC

✅ ./benchmarks/nns/canbench_results.yml is up to date
📦 canbench_results_nns.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median -163 | p25 -748.72K | min -41.32M]
    change %: [max 0.00% | p75 0.00% | median -0.04% | p25 -0.28% | min -0.57%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

github-actions · 2026-04-02T13:27:27Z

`canbench` 🏋 (dir: ./benchmarks/btreeset) `30950fc` 2026-04-02 13:36:00 UTC

✅ ./benchmarks/btreeset/canbench_results.yml is up to date
📦 canbench_results_btreeset.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   Regressions detected 🔴
    counts:   [total 100 | regressed 3 | improved 0 | new 0 | unchanged 97]
    change:   [max +149.75K | p75 +7.79K | median +641 | p25 -12.79K | min -3.76M]
    change %: [max +2.70% | p75 +0.11% | median 0.01% | p25 -0.04% | min -0.40%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 100 | regressed 0 | improved 0 | new 0 | unchanged 100]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------

Only significant changes:
| status | name                      | calls |    ins |  ins Δ% | HI |  HI Δ% | SMI |  SMI Δ% |
|--------|---------------------------|-------|--------|---------|----|--------|-----|---------|
|   +    | btreeset_is_subset_u64    |       | 44.42K |  +2.70% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreeset_is_subset_u32    |       | 43.52K |  +2.51% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreeset_is_subset_blob_8 |       | 52.86K |  +2.09% |  0 |  0.00% |   0 |   0.00% |

ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change

---------------------------------------------------
CSV results saved to canbench_results.csv

maksymar added 3 commits April 2, 2026 15:03

refactor: store nodes as Rc in cache

f38bab7

refactor, cached node type

1700767

box

396428d

rm cached node type

9c69ff5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: store nodes as Rc in cache#429

refactor: store nodes as Rc in cache#429
maksymar wants to merge 4 commits intomainfrom
maksym/cache-rc-node

maksymar commented Apr 2, 2026

Uh oh!

github-actions bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

maksymar commented Apr 2, 2026

Uh oh!

github-actions bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

canbench 🏋 (dir: ./benchmarks/vec) 30950fc 2026-04-02 13:35:45 UTC

Uh oh!

github-actions bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

canbench 🏋 (dir: ./benchmarks/btreemap) 30950fc 2026-04-02 13:37:17 UTC

Uh oh!

github-actions bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

canbench 🏋 (dir: ./benchmarks/io_chunks) 30950fc 2026-04-02 13:36:41 UTC

Uh oh!

github-actions bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

canbench 🏋 (dir: ./benchmarks/memory_manager) 30950fc 2026-04-02 13:35:43 UTC

Uh oh!

github-actions bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

canbench 🏋 (dir: ./benchmarks/nns) 30950fc 2026-04-02 13:35:59 UTC

Uh oh!

github-actions bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

canbench 🏋 (dir: ./benchmarks/btreeset) 30950fc 2026-04-02 13:36:00 UTC

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Apr 2, 2026 •

edited

Loading

`canbench` 🏋 (dir: ./benchmarks/vec) `30950fc` 2026-04-02 13:35:45 UTC

github-actions bot commented Apr 2, 2026 •

edited

Loading

`canbench` 🏋 (dir: ./benchmarks/btreemap) `30950fc` 2026-04-02 13:37:17 UTC

github-actions bot commented Apr 2, 2026 •

edited

Loading

`canbench` 🏋 (dir: ./benchmarks/io_chunks) `30950fc` 2026-04-02 13:36:41 UTC

github-actions bot commented Apr 2, 2026 •

edited

Loading

`canbench` 🏋 (dir: ./benchmarks/memory_manager) `30950fc` 2026-04-02 13:35:43 UTC

github-actions bot commented Apr 2, 2026 •

edited

Loading

`canbench` 🏋 (dir: ./benchmarks/nns) `30950fc` 2026-04-02 13:35:59 UTC

github-actions bot commented Apr 2, 2026 •

edited

Loading

`canbench` 🏋 (dir: ./benchmarks/btreeset) `30950fc` 2026-04-02 13:36:00 UTC