Skip to content

feat(agent)!: use /api/v4 for call requests #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: luca/new-certificates-ranges
Choose a base branch
from
Open

feat(agent)!: use /api/v4 for call requests #1223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08b1257
feat(agent): use `/api/v4` for call requests
ilbertt Nov 26, 2025
b1b4c1f
chore: update changelog
ilbertt Nov 26, 2025
0395a9c
chore: update changelog
ilbertt Nov 26, 2025
50e21bc
test: update snapshots
ilbertt Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
## [Unreleased]

- feat(core)!: removes `@dfinity/{agent,candid,identity,identity-secp256k1,principal}` peer dependencies and moves their source code to the `@icp-sdk/core` package
- feat(agent)!: use `/api/v4` for call requests
- Renames `v3ResponseBody` to `v4ResponseBody`
- Renames `isV3ResponseBody` to `isV4ResponseBody`
- Renames `HttpV3ApiNotSupportedErrorCode` to `HttpV4ApiNotSupportedErrorCode`
- feat(assets)!: replaces `@dfinity/{agent,candid,principal}` deps with `@icp-sdk/core`
- feat(assets)!: drops support for cjs for the `@dfinity/assets` package
- feat(auth-client)!: `@dfinity/auth-client` has been deprecated. Migrate to [`@icp-sdk/auth`](https://js.icp.build/auth/latest/upgrading/v4)
Expand Down
26 changes: 13 additions & 13 deletions e2e/node/basic/__snapshots__/syncTime.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`syncTime > on async creation > should sync time on when enabled > V3 read state body one 1`] = `
exports[`syncTime > on async creation > should sync time on when enabled > V4 read state body one 1`] = `
{
"content": {
"ingress_expiry": 1746103140000000000n,
Expand All @@ -23,7 +23,7 @@ exports[`syncTime > on async creation > should sync time on when enabled > V3 re
}
`;

exports[`syncTime > on async creation > should sync time on when enabled > V3 read state body three 1`] = `
exports[`syncTime > on async creation > should sync time on when enabled > V4 read state body three 1`] = `
{
"content": {
"ingress_expiry": 1746103140000000000n,
Expand All @@ -46,7 +46,7 @@ exports[`syncTime > on async creation > should sync time on when enabled > V3 re
}
`;

exports[`syncTime > on async creation > should sync time on when enabled > V3 read state body two 1`] = `
exports[`syncTime > on async creation > should sync time on when enabled > V4 read state body two 1`] = `
{
"content": {
"ingress_expiry": 1746103140000000000n,
Expand All @@ -69,7 +69,7 @@ exports[`syncTime > on async creation > should sync time on when enabled > V3 re
}
`;

exports[`syncTime > on error > should not sync time by default > V3 call body 1`] = `
exports[`syncTime > on error > should not sync time by default > V4 call body 1`] = `
{
"content": {
"arg": {
Expand Down Expand Up @@ -139,7 +139,7 @@ exports[`syncTime > on error > should sync time when the local time does not mat
}
`;

exports[`syncTime > on error > should sync time when the local time does not match the subnet time > V3 call body 1`] = `
exports[`syncTime > on error > should sync time when the local time does not match the subnet time > V4 call body 1`] = `
{
"content": {
"arg": {
Expand Down Expand Up @@ -186,7 +186,7 @@ exports[`syncTime > on error > should sync time when the local time does not mat
}
`;

exports[`syncTime > on error > should sync time when the local time does not match the subnet time > V3 read state body three 1`] = `
exports[`syncTime > on error > should sync time when the local time does not match the subnet time > V4 read state body three 1`] = `
{
"content": {
"ingress_expiry": 1746103140000000000n,
Expand All @@ -209,7 +209,7 @@ exports[`syncTime > on error > should sync time when the local time does not mat
}
`;

exports[`syncTime > on error > should sync time when the local time does not match the subnet time > V3 read state body two 1`] = `
exports[`syncTime > on error > should sync time when the local time does not match the subnet time > V4 read state body two 1`] = `
{
"content": {
"ingress_expiry": 1746103140000000000n,
Expand All @@ -232,7 +232,7 @@ exports[`syncTime > on error > should sync time when the local time does not mat
}
`;

exports[`syncTime > on first call > should not sync time by default > V3 call body 1`] = `
exports[`syncTime > on first call > should not sync time by default > V4 call body 1`] = `
{
"content": {
"arg": {
Expand Down Expand Up @@ -279,7 +279,7 @@ exports[`syncTime > on first call > should not sync time by default > V3 call bo
}
`;

exports[`syncTime > on first call > should not sync time when explicitly disabled > V3 call body 1`] = `
exports[`syncTime > on first call > should not sync time when explicitly disabled > V4 call body 1`] = `
{
"content": {
"arg": {
Expand Down Expand Up @@ -326,7 +326,7 @@ exports[`syncTime > on first call > should not sync time when explicitly disable
}
`;

exports[`syncTime > on first call > should sync time when enabled > V3 call body 1`] = `
exports[`syncTime > on first call > should sync time when enabled > V4 call body 1`] = `
{
"content": {
"arg": {
Expand Down Expand Up @@ -373,7 +373,7 @@ exports[`syncTime > on first call > should sync time when enabled > V3 call body
}
`;

exports[`syncTime > on first call > should sync time when enabled > V3 read state body one 1`] = `
exports[`syncTime > on first call > should sync time when enabled > V4 read state body one 1`] = `
{
"content": {
"ingress_expiry": 1746103140000000000n,
Expand All @@ -396,7 +396,7 @@ exports[`syncTime > on first call > should sync time when enabled > V3 read stat
}
`;

exports[`syncTime > on first call > should sync time when enabled > V3 read state body three 1`] = `
exports[`syncTime > on first call > should sync time when enabled > V4 read state body three 1`] = `
{
"content": {
"ingress_expiry": 1746103140000000000n,
Expand All @@ -419,7 +419,7 @@ exports[`syncTime > on first call > should sync time when enabled > V3 read stat
}
`;

exports[`syncTime > on first call > should sync time when enabled > V3 read state body two 1`] = `
exports[`syncTime > on first call > should sync time when enabled > V4 read state body two 1`] = `
{
"content": {
"ingress_expiry": 1746103140000000000n,
Expand Down
Loading
Loading