Skip to content

feat: Implement slip-0010 and seed-curve arg#501

Merged
lwshang merged 7 commits intomainfrom
spofford/slip-0010
Apr 17, 2026
Merged

feat: Implement slip-0010 and seed-curve arg#501
lwshang merged 7 commits intomainfrom
spofford/slip-0010

Conversation

@adamspofford-dfinity
Copy link
Copy Markdown
Contributor

No description provided.

@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner April 14, 2026 22:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds SLIP-0010-based key derivation from BIP-39 seed phrases and exposes a --seed-curve CLI option so seed imports can generate non-secp256k1 identities.

Changes:

  • Implement SLIP-0010 derivation for secp256k1, P-256, and ed25519 and expose a new derive_key_from_seed_slip10 helper.
  • Extend icp identity import with --seed-curve and add CLI integration tests for p256/ed25519 seed imports.
  • Add hmac dependency wiring and update docs/changelog accordingly.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docs/reference/cli.md Documents the new --seed-curve option for identity import.
crates/icp/src/identity/seed/slip10.rs New SLIP-0010 derivation implementation for secp256k1/p256/ed25519.
crates/icp/src/identity/seed/mod.rs New seed module API: standard derivation paths + derive_key_from_seed_slip10.
crates/icp/src/identity/seed.rs Removes the previous BIP32-based default seed derivation helper.
crates/icp/Cargo.toml Adds hmac dependency to support SLIP-0010 derivation.
crates/icp-cli/tests/identity_tests.rs Adds coverage for --seed-curve with p256 and ed25519 principals.
crates/icp-cli/src/commands/identity/new.rs Switches identity creation-from-seed to the new SLIP-0010 helper.
crates/icp-cli/src/commands/identity/import.rs Adds --seed-curve flag and routes seed imports through SLIP-0010 derivation.
Cargo.toml Adds workspace dependency version for hmac.
Cargo.lock Locks hmac as a dependency.
CHANGELOG.md Notes the new --seed-curve import feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/icp-cli/src/commands/identity/import.rs
Comment thread crates/icp/src/identity/seed/slip10.rs
Comment thread crates/icp/src/identity/seed/slip10.rs Outdated
@lwshang lwshang enabled auto-merge (squash) April 17, 2026 00:29
@lwshang lwshang merged commit cb6665d into main Apr 17, 2026
93 checks passed
@lwshang lwshang deleted the spofford/slip-0010 branch April 17, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants