fix: rewrite canister settings show to only output settings#499
Merged
fix: rewrite canister settings show to only output settings#499
canister settings show to only output settings#499Conversation
Previously the command delegated entirely to `canister status`, which fell back to public state-tree data when the caller was not a controller and showed the full status result. The command now calls `canister_status` directly, errors on non-controller callers, and outputs only the settings fields using `DefiniteCanisterSettings`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r all settings fields Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adamspofford-dfinity
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icp canister settings showpreviously output a full canister status header (canister ID, module hash, status, memory size, cycles) in addition to the settings fields, which was inconsistent with the command namecanister_statusbut display only thesettingsportion of the response--jsonflag to output settings as JSONTest plan
cargo test -p icp-cli --test canister_settings_tests -- canister_settings_showcargo test -p icp-cli --test canister_settings_tests(full suite)🤖 Generated with Claude Code