DO NOT MERGE UNTIL NNS HAS BEEN SUFFICIENTLY UPGRADED test(nns): Allow using production versions of NNS canisters in standard_engine_replica_version_test - #11266
Draft
daniel-wong-dfinity-org-twin wants to merge 1 commit into
Conversation
…plica_ve…" This reverts commit 854f78a.
daniel-wong-dfinity-org-twin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #11248
PR 11248 was needed, because relaxed validation rules had not yet reached production. The relaxed rules were in regards to replica versions used by StandardEngineReplicaVersion. Because the production code was more strict, the test would fail with
This will be merged after the relaxed rules go into production. In the meantime, the
_head_nnsversion of this test still works, and is valuable, because it tells us if a version that we might try to put into production might be broken.