Skip to content

feat(cketh): expose per-token minimum deposit amounts in MinterInfo - #11251

Open
gregorydemay wants to merge 1 commit into
gdemay/DEFI-2926_expose_sweeper_addressfrom
gdemay/DEFI-2962_expose_minimum_deposit_amounts
Open

feat(cketh): expose per-token minimum deposit amounts in MinterInfo#11251
gregorydemay wants to merge 1 commit into
gdemay/DEFI-2926_expose_sweeper_addressfrom
gdemay/DEFI-2962_expose_minimum_deposit_amounts

Conversation

@gregorydemay

@gregorydemay gregorydemay commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Balance-scan filter 1 only treats a deposit address as a scan candidate once its balance reaches a per-token minimum, so a smaller deposit is silently never detected and never credited. For the CEX deposit flow that threshold was invisible: a user could send a small amount to their deposit address, see nothing happen, and have no way to find out why.

get_minter_info now reports minimum_deposit_amounts — the minimum for each supported ckERC20 token, in that token's own units — so users and frontends can show the threshold alongside the deposit address. It is null while the ckERC20 feature is inactive, matching the existing per-token fields.

The thresholds are still the hard-coded rate snapshot; they will start tracking live prices once DEFI-2961's daily exchange-rate refresh lands, and this endpoint will reflect that automatically.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the feat label Aug 21, 2026
@gregorydemay
gregorydemay marked this pull request as ready for review August 21, 2026 08:37
@gregorydemay
gregorydemay requested a review from a team as a code owner August 21, 2026 08:37
@github-actions github-actions Bot added the @defi label Aug 21, 2026
@zeropath-ai

zeropath-ai Bot commented Aug 21, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 42be041.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► rs/ethereum/cketh/minter/src/balance_scan/mod.rs
     Minimum balance for token to count as a scan candidate; expose as public function
► rs/ethereum/cketh/minter/src/endpoints.rs
     Add Erc20MinimumDeposit struct and integrate into MinterInfo
► rs/ethereum/cketh/minter/src/main.rs
     Use min_deposit in get_minter_info
► rs/ethereum/cketh/minter/src/main.rs
     Import min_deposit and balance_scan together
► rs/ethereum/cketh/minter/src/main.rs
     Update get_minter_info to include minimum_deposit_amounts in response
► rs/ethereum/cketh/minter/tests/ckerc20.rs
     Update tests to account for Erc20MinimumDeposit in MinterInfo
► rs/ethereum/cketh/minter/tests/cketh.rs
     Adjust tests to reflect new minimum_deposit_amounts field in MinterInfo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant