feat: Cache and reuse registry data across rounds#10639
Merged
Conversation
This is the first step of consolidating the various SystemMetadata fields populated from the registry under NetworkTopology (for network-wide information), on the one hand; and a similar SubnetTopology (for subnet-related information), on the other. Once all this consolidation is complete, we can reuse the two structs (wrapped in Arcs in SystemMetadata) from one ReplicatedState to the next, iff they use the same registry version.
…struct Bundle `SystemMetadata` fields `own_subnet_features`, `own_resource_limits` and `node_public_keys` into an `OwnSubnetInfo` struct, in preparation for easy reuse across `ReplicatedStates` using the same registry version.
Cache previously read registry values (`NetworkTopology`, `OwnSubnetInfo` and `RegistryExecutionSettings`) along with the registry version they were read at. On the next registry read (during the next execution round), if the same registry version is being requested, return the cached values. Reading the registry is now about 50% of the (admittedly already low) DSM overhead (~20 ms of a total ~40 ms; which is still 10% of the average 400 ms round).
|
✅ No security or compliance issues detected. Reviewed everything up to 8a97392. Security Overview
Detected Code Changes
|
michael-weigelt
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache previously read registry values (
NetworkTopology,OwnSubnetInfoandRegistryExecutionSettings) along with the registry version they were read at. On the next registry read (during the next execution round), if the same registry version is requested, return the cached values.Reading the registry is now about 50% of the (admittedly already low) DSM overhead (~20 ms of a total ~40 ms; which is still 10% of the average 400 ms round).