perf: Speed up creating_canisters_always_works test#10276
Open
alin-at-dfinity wants to merge 3 commits into
Open
perf: Speed up creating_canisters_always_works test#10276alin-at-dfinity wants to merge 3 commits into
alin-at-dfinity wants to merge 3 commits into
Conversation
Looks like commit 41fdff3 has caused test creating_canisters_always_works_if_limit_is_set_to_zero to slow down to 60+ seconds (potentially because of the overhead of encoding and decoding the CreateCanisterArgs. Batch the CreateCanister calls to speed the test up to under 1 second.
schneiderstefan
approved these changes
May 22, 2026
mraszyk
reviewed
May 22, 2026
mraszyk
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like commit 41fdff3 has caused test
creating_canisters_always_works_if_limit_is_set_to_zeroto slow down to 60+ seconds (potentially because of the overhead of encoding and decoding theCreateCanisterArgs.Batch the
CreateCanistercalls to speed the test up to under 1 second.