Repository navigation
feat(minter): report the automatic deposit flow in the metrics and on the dashboard - #287
Draft
gregorydemay wants to merge 6 commits into
Draft
gregorydemay wants to merge 6 commits into
gregorydemay wants to merge 6 commits into
Conversation
gregorydemay
added this pull request to stack #288
October 14, 2026 08:50
gregorydemay
force-pushed
the
DEFI-2780-12-automatic-flow-metrics
branch
from
October 14, 2026 09:04
1de2d70 to
9820615
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The dashboard can display expired registrations as actively watched addresses.
1 open finding
What changed in this PR
Adds observability for the automatic deposit flow through metrics and the minter dashboard.
Changes:
- Adds watchlist, queued-deposit, age, and fee metrics.
- Adds fee metadata and a paginated watched-address table.
- Extends dashboard and integration tests.
| File | Description |
|---|---|
minter/templates/dashboard.html |
Renders fees and watched addresses. |
minter/src/metrics.rs |
Exposes automatic-deposit metrics. |
minter/src/dashboard/tests.rs |
Tests dashboard additions and pagination. |
minter/src/dashboard/mod.rs |
Builds new dashboard data and pagination. |
integration_tests/tests/tests.rs |
Checks exported metrics. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gregorydemay
force-pushed
the
DEFI-2780-12-automatic-flow-metrics
branch
from
October 14, 2026 09:18
9820615 to
9180e71
Compare
gregorydemay
force-pushed
the
DEFI-2780-12-automatic-flow-metrics
branch
from
October 14, 2026 09:20
9180e71 to
ecc34b0
Compare
Comment on lines
+133
to
+136
| w.encode_gauge( | ||
| "collected_automatic_deposit_fees", | ||
| s.collected_automatic_deposit_fees().metric_value(), | ||
| "Sum in Lamports of the automatic deposit fees deducted from the mints of credited sweeps.", |
gregorydemay
force-pushed
the
DEFI-2780-12-automatic-flow-metrics
branch
from
October 14, 2026 09:35
ecc34b0 to
c0f5880
Compare
gregorydemay
force-pushed
the
DEFI-2780-12-automatic-flow-metrics
branch
from
October 14, 2026 09:56
c0f5880 to
cbf0ec6
Compare
gregorydemay
force-pushed
the
DEFI-2780-12-automatic-flow-metrics
branch
from
October 14, 2026 11:19
cbf0ec6 to
5becaab
Compare
gregorydemay
force-pushed
the
DEFI-2780-12-automatic-flow-metrics
branch
from
October 15, 2026 09:04
53d23ff to
e4b1a94
Compare
gregorydemay
force-pushed
the
DEFI-2780-12-automatic-flow-metrics
branch
from
October 15, 2026 09:54
e4b1a94 to
4c30148
Compare
gregorydemay
force-pushed
the
DEFI-2780-12-automatic-flow-metrics
branch
from
October 15, 2026 11:28
4c30148 to
e01e743
Compare
… the dashboard Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… dashboard Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…isting Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…lone Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…e scan outcomes alone Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reports the automatic deposit flow of #272 in the metrics (watched addresses, age of the oldest registration, scans by outcome, collected fees) and on the dashboard (the fee parameter, the collected fees and a paginated table of the watched addresses).
🤖 Generated with Claude Code