feat(minter): re-arm the automatic deposits of a dropped sweep by gregorydemay · Pull Request #284 · dfinity/cksol

gregorydemay · 2026-10-14T08:49:10Z

When the sweep of a deposit detected by the automatic deposit flow of #272 fails or expires, the account is put back on the watchlist for a fresh window, if the watchlist has room, so that the funds still on the deposit address are swept again without the user's intervention. Covered by unit tests of the re-arm and of the replay of the event log.

🤖 Generated with Claude Code

Copilot

🟡 Changes recommended

Re-arm outcomes depend on transient watchlist capacity and therefore diverge during event replay.

1 open finding

Persist watchlist re-arm outcomes for deterministic replay · New

What changed in this PR

Re-arms automatic deposits after failed or expired sweeps.

Changes:

Adds watchlist re-arm logic and failure handling.
Returns dropped deposits for re-registration.
Adds tests and updates design documentation.

File	Description
`minter/src/state/watchlist/tests.rs`	Tests re-arm behavior.
`minter/src/state/watchlist/mod.rs`	Implements watchlist re-arming.
`minter/src/state/tests.rs`	Tests sweep failure and replay.
`minter/src/state/mod.rs`	Re-arms deposits when sweeps are dropped.
`minter/src/state/deposits/tests.rs`	Tests returned dropped deposits.
`minter/src/state/deposits/mod.rs`	Returns deposits from dropped sweeps.
`minter/src/state/audit.rs`	Passes event timestamps during replay.
`docs/src/development/design.md`	Documents restored watch windows.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+    /// addresses are swept again without the user's intervention.
+    fn drop_sweep(&mut self, signature: &Signature, timestamp: u64) {
+        for deposit in self.deposits.drop_swept(signature) {
+            let rearmed = self.watchlist.rearm(timestamp, &deposit);


Copilot

🔵 Needs a closer look

Re-arm decisions can differ during event replay because watchlist capacity depends on unlogged transient registrations.

1 open finding

Persist watchlist re-arm outcomes for deterministic replay

🧠 Review effort: Balanced

Copilot

🟢 Approval recommended

The implementation is deterministic under event replay and covers expiry, capacity, manual deposits, and both drop paths.

1 open finding

Persist watchlist re-arm outcomes for deterministic replay

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

Re-arm admission depends on transient watchlist capacity and can produce different state during event replay.

1 open finding

Persist watchlist re-arm outcomes for deterministic replay

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

Re-arm admission is recomputed from unrecorded transient watchlist state, allowing replay to produce different behavior after an upgrade.

1 open finding

Persist watchlist re-arm outcomes for deterministic replay

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

Re-arm capacity decisions depend on transient watchlist state and can differ during event replay.

2 open findings

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

Upgrade replay does not preserve watchlist capacity decisions or subsequent scan progress.

2 open findings

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

Missing watchlist persistence allows upgrade replay to change re-arm outcomes and reset scan progress.

2 open findings

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

Capacity-dependent re-arm decisions can differ during event replay because live watchlist registrations are not restored.

2 open findings

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

Upgrade replay can admit re-arms rejected by the live capacity check because transient watchlist registrations are not restored.

2 open findings

🧠 Review effort: Balanced

Copilot

🟢 Approval recommended

The focused changes preserve capacity limits and manual-deposit behavior, with tests covering failure, expiry, and replay.

2 open findings

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

The previously reported replay issue remains unresolved: transient watchlist capacity can produce different re-arm decisions after an upgrade.

2 open findings

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

Replay safety depends on watchlist persistence, which remains unverified.

2 open findings

🧠 Review effort: Balanced

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

…re-arm test Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

The re-arm registers the account again instead of restoring the window end recorded with the deposit, so a drop after the original window re-arms as well and the window-closed error disappears. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

…w name Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Copilot

🔵 Needs a closer look

Event replay can change re-arm decisions and reset scan progress because the live watchlist is not restored.

2 open findings

🧠 Review effort: Balanced

gregorydemay added this pull request to stack #288 October 14, 2026 08:50

Copilot AI balanced review requested due to automatic review settings October 14, 2026 09:04

gregorydemay force-pushed the DEFI-2780-09-rearm-dropped-sweeps branch from cbcba4e to 0df76d9 Compare October 14, 2026 09:04

Copilot started reviewing on behalf of gregorydemay October 14, 2026 09:05

View session