-
-
Notifications
You must be signed in to change notification settings - Fork 8
Add --version flag to SafeDITool #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| #!/bin/bash | ||
|
|
||
| # This script checks that the version string is consistent across all files | ||
| # that contain it. Run this in CI to catch version mismatches. | ||
|
|
||
| set -e | ||
|
|
||
| # Helper function to extract and validate a version | ||
| extract_version() { | ||
| local file="$1" | ||
| local pattern="$2" | ||
| local context_lines="$3" | ||
| local quote_char="$4" | ||
|
|
||
| local version | ||
| version=$(grep -A"$context_lines" "$pattern" "$file" | grep -o "${quote_char}[0-9]*\.[0-9]*\.[0-9]*${quote_char}" | tr -d "$quote_char") | ||
|
|
||
| local count | ||
| count=$(echo "$version" | grep -c . || true) | ||
|
|
||
| if [ -z "$version" ]; then | ||
| echo "ERROR: Could not find version in $file" >&2 | ||
| return 1 | ||
| elif [ "$count" -gt 1 ]; then | ||
| echo "ERROR: Found multiple versions in $file: $version" >&2 | ||
| return 1 | ||
| fi | ||
|
|
||
| echo "$version" | ||
| } | ||
|
|
||
| echo "Checking version consistency..." | ||
|
|
||
| # Extract version from SafeDITool.swift (looks for the line after "static var currentVersion") | ||
| TOOL_VERSION=$(extract_version "Sources/SafeDITool/SafeDITool.swift" "static var currentVersion" 1 '"') | ||
| echo " SafeDITool.swift: $TOOL_VERSION" | ||
|
|
||
| # Extract version from Plugins/Shared.swift (the safeDIVersion property in XcodePluginContext) | ||
| PLUGIN_VERSION=$(extract_version "Plugins/Shared.swift" "var safeDIVersion: String" 4 '"') | ||
| echo " Plugins/Shared.swift: $PLUGIN_VERSION" | ||
|
|
||
| # Extract version from SafeDI.podspec | ||
| PODSPEC_VERSION=$(extract_version "SafeDI.podspec" "s.version" 0 "'") | ||
| echo " SafeDI.podspec: $PODSPEC_VERSION" | ||
|
|
||
| if [ "$TOOL_VERSION" != "$PLUGIN_VERSION" ] || [ "$TOOL_VERSION" != "$PODSPEC_VERSION" ]; then | ||
| echo "ERROR: Version mismatch detected!" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "All versions match: $TOOL_VERSION" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| // Distributed under the MIT License | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in all | ||
| // copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| // SOFTWARE. | ||
|
|
||
| import Foundation | ||
| import Testing | ||
|
|
||
| #if os(Linux) | ||
| import Glibc | ||
| #else | ||
| import Darwin | ||
| #endif | ||
|
|
||
| @testable import SafeDITool | ||
|
|
||
| @MainActor // serialized due to changes to stdout | ||
| struct SafeDIToolVersionTests { | ||
| @Test | ||
| func run_withVersionFlag_printsCurrentVersion() async throws { | ||
| var tool = SafeDITool() | ||
| tool.swiftSourcesFilePath = nil | ||
| tool.showVersion = true | ||
| tool.include = [] | ||
| tool.includeFilePath = nil | ||
| tool.additionalImportedModules = [] | ||
| tool.additionalImportedModulesFilePath = nil | ||
| tool.moduleInfoOutput = nil | ||
| tool.dependentModuleInfoFilePath = nil | ||
| tool.dependencyTreeOutput = nil | ||
| tool.dotFileOutput = nil | ||
|
|
||
| let output = try await captureStandardOutput { | ||
| try await tool.run() | ||
| } | ||
|
|
||
| let trimmedOutput = output.trimmingCharacters(in: .whitespacesAndNewlines) | ||
| #expect(trimmedOutput == SafeDITool.currentVersion) | ||
| } | ||
|
|
||
| private func captureStandardOutput(_ block: () async throws -> Void) async throws -> String { | ||
| let pipe = Pipe() | ||
| let originalStdout = dup(STDOUT_FILENO) | ||
| dup2(pipe.fileHandleForWriting.fileDescriptor, STDOUT_FILENO) | ||
|
|
||
| try await block() | ||
|
|
||
| pipe.fileHandleForWriting.closeFile() | ||
| dup2(originalStdout, STDOUT_FILENO) | ||
| close(originalStdout) | ||
|
|
||
| return String(data: pipe.fileHandleForReading.availableData, encoding: .utf8) ?? "" | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.